|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH 4/5] tcg: reorder removal from lists in tb_phys_invalidate |
| Date: | Thu, 14 Apr 2016 19:27:07 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 14/04/2016 17:36, Sergey Fedorov wrote: > IIUC we always modify tb_jmp_cache/tb_phys_hash under tb_lock. We're > just gonna do tb_jmp_cache lookup outside of tb_lock. I think write > memory barrier in tb_phys_invalidate() paired with read memory memory > barrier in tb_find_fast()/tb_find_slow() would be enough to make it > safe. Also we need to use atomic read/set to tb_jmp_cache but cmpxchg is > not necessary. So I'm going to give it a thought then. Sounds good! Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |