Re: [Qemu-devel] [PATCH 0/2] ppc: Fixes for LSWX and LSWI instructions

[Mark Cave-Ayland]

On 14/04/16 16:14, Thomas Huth wrote:

> These two patches fix the bad range checks in the LSWI and LSWX
> instructions.
> 
> To see the change in behavior for the lswx instruction, you can use the
> "emulator" test from the kvm-unit-tests suite - code can be found here:
> 
> https://git.kernel.org/cgit/virt/kvm/kvm-unit-tests.git/tree/powerpc/emulator.c#n95
> 
> For testing the lswi instruction, an additional kvm-unit-test can be
> used, see the patch that I've posted here:
> 
> https://patchwork.ozlabs.org/patch/610483/
> 
> 
> Thomas Huth (2):
>   ppc: Fix the range check in the LSWI instruction
>   ppc: Fix the bad exception NIP value and the range check in LSWX
> 
>  target-ppc/cpu.h        | 10 ++++++++++
>  target-ppc/mem_helper.c |  5 +++--
>  target-ppc/translate.c  |  6 ++----
>  3 files changed, 15 insertions(+), 6 deletions(-)

I see David has already queued these, however I did give them a spin on
my OpenBIOS PPC test images and didn't see any obvious regressions.


ATB,

Mark.