[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if no

From: Sascha Silbe
Subject: Re: [Qemu-devel] [PATCH for-2.6?] qemu-iotests: iotests: fail hard if not run via "check"
Date: Tue, 19 Apr 2016 18:49:55 +0200
User-agent: Notmuch/0.19+1~g6b3e223 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu)

Dear Markus,

Markus Armbruster <address@hidden> writes:

> Say you had an accurate way to find out whether we're running under
> "check".  You could then reject any attempt to run the test directly.
> I'd oppose that.
> It's okay to have test wrapper scripts to configure the tests just so.
> It's okay to tell people to use them.  But "you can't do that, Dave" is
> not okay. [...]

AFAICT the environment in which the individual test cases run isn't
well-defined. Currently it's indirectly defined by whatever "check"

The goal of the patch is to catch unwary developers invoking the tests
directly from the command line, providing them with useful advice. If
somebody wants to write another test runner (in place of "check"), it's
their responsibility to set up the environment appropriately. (They
could even set an environment variable "I_AM_CHECK=yes" if that's part
of the environment the tests expect).

I'd be perfectly fine with defining the environment more clearly and
possibly extending the implementation to allow individual test cases to
be invoked directly (without a test runner like "check"). But that would
be 2.7 material.

Softwareentwicklung Sascha Silbe, Niederhofenstra├če 5/1, 71229 Leonberg
USt-IdNr. DE281696641

reply via email to

[Prev in Thread] Current Thread [Next in Thread]