[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/10] qht: add test program
From: |
Emilio G. Cota |
Subject: |
Re: [Qemu-devel] [PATCH 09/10] qht: add test program |
Date: |
Tue, 19 Apr 2016 19:06:00 -0400 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Apr 08, 2016 at 11:45:41 +0100, Alex Bennée wrote:
(snip the entire patch)
> A couple of notes:
>
> - these should use the gtester boiler plate for reporting results
Done in v3.
> - AFAICT they are not exercising the multi-element hashing we actually
> use in the main code
> - it would be nice to add a check on the bucket/map distribution to
> defend against the algorithm being accidentally weakened with follow up
> patches
I added tb hash chain info to 'info jit' to keep track of this. My goal
with the test program is to check that the hash table is correct; I'd
rather check performance with QEMU than with a made-up test, since
it is QEMU's performance what we care about.
Thanks,
Emilio