[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 44/50] arm: move arm_log_exception into .c file
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 44/50] arm: move arm_log_exception into .c file |
Date: |
Thu, 21 Apr 2016 11:48:29 +0100 |
User-agent: |
mu4e 0.9.17; emacs 25.0.92.6 |
Paolo Bonzini <address@hidden> writes:
> Avoid need for qemu/log.h inclusion, and make the function static too.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> target-arm/helper.c | 15 +++++++++++++++
> target-arm/internals.h | 15 ---------------
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index 09638b2..41abdff 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -5815,6 +5815,21 @@ static void do_v7m_exception_exit(CPUARMState *env)
> pointer. */
> }
>
> +static void arm_log_exception(int idx)
> +{
> + if (qemu_loglevel_mask(CPU_LOG_INT)) {
> + const char *exc = NULL;
> +
> + if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
> + exc = excnames[idx];
> + }
> + if (!exc) {
> + exc = "unknown";
> + }
> + qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
> + }
> +}
> +
> void arm_v7m_cpu_do_interrupt(CPUState *cs)
> {
> ARMCPU *cpu = ARM_CPU(cs);
> diff --git a/target-arm/internals.h b/target-arm/internals.h
> index 2e70272..c484700 100644
> --- a/target-arm/internals.h
> +++ b/target-arm/internals.h
> @@ -72,21 +72,6 @@ static const char * const excnames[] = {
> [EXCP_SEMIHOST] = "Semihosting call",
> };
>
> -static inline void arm_log_exception(int idx)
> -{
> - if (qemu_loglevel_mask(CPU_LOG_INT)) {
> - const char *exc = NULL;
> -
> - if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
> - exc = excnames[idx];
> - }
> - if (!exc) {
> - exc = "unknown";
> - }
> - qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
> - }
> -}
> -
> /* Scale factor for generic timers, ie number of ns per tick.
> * This gives a 62.5MHz timer.
> */
--
Alex Bennée
- Re: [Qemu-devel] [PATCH 38/50] qemu-common: stop including qemu/host-utils.h from qemu-common.h, (continued)
- [Qemu-devel] [PATCH 42/50] acpi: do not use TARGET_PAGE_SIZE, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 41/50] s390x: move stuff out of cpu.h, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 39/50] gdbstub: remove includes from gdbstub-xml.c, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 43/50] qemu-common: push cpu.h inclusion out of qemu-common.h, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 40/50] dma: do not depend on kvm_enabled(), Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 44/50] arm: move arm_log_exception into .c file, Paolo Bonzini, 2016/04/08
- Re: [Qemu-devel] [PATCH 44/50] arm: move arm_log_exception into .c file,
Alex Bennée <=
- [Qemu-devel] [PATCH 45/50] mips: move CP0 functions out of cpu.h, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 49/50] hw: remove pio_addr_t, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 46/50] hw: explicitly include qemu/log.h, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 47/50] exec: extract exec/tb-context.h, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 50/50] hw: clean up hw/hw.h includes, Paolo Bonzini, 2016/04/08
- [Qemu-devel] [PATCH 48/50] cpu: move exec-all.h inclusion out of cpu.h, Paolo Bonzini, 2016/04/08
- Re: [Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H / cpu.h / hw/hw.h cleanups, Markus Armbruster, 2016/04/18
- Re: [Qemu-devel] [PATCH for-2.7 00/49] NEED_CPU_H / cpu.h / hw/hw.h cleanups, Markus Armbruster, 2016/04/18