[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as e
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external |
Date: |
Fri, 22 Apr 2016 16:44:20 +0300 |
On Fri, Apr 22, 2016 at 06:56:02PM +0800, Fam Zheng wrote:
> The effect of this change is the block layer drained section can work,
> for example when mirror job is being completed.
>
> Signed-off-by: Fam Zheng <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/virtio/virtio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> index fffa09f..30ede3d 100644
> --- a/hw/virtio/virtio.c
> +++ b/hw/virtio/virtio.c
> @@ -1829,10 +1829,10 @@ void
> virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign,
> bool set_handler)
> {
> if (assign && set_handler) {
> - event_notifier_set_handler(&vq->host_notifier, false,
> + event_notifier_set_handler(&vq->host_notifier, true,
> virtio_queue_host_notifier_read);
> } else {
> - event_notifier_set_handler(&vq->host_notifier, false, NULL);
> + event_notifier_set_handler(&vq->host_notifier, true, NULL);
> }
> if (!assign) {
> /* Test and clear notifier before after disabling event,
> --
> 2.8.0
- [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 1/5] iohandler: Introduce iohandler_get_aio_context, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 2/5] event-notifier: Add "is_external" parameter, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external, Fam Zheng, 2016/04/22
- Re: [Qemu-devel] [PATCH v2 for-2.6 3/5] virtio: Mark host notifiers as external,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH v2 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch, Fam Zheng, 2016/04/22
- [Qemu-devel] [PATCH v2 for-2.6 5/5] mirror: Workaround for unexpected iohandler events during completion, Fam Zheng, 2016/04/22
- Re: [Qemu-devel] [PATCH v2 for-2.6 0/5] block: Fix assertion failure at mirror exit, Michael S. Tsirkin, 2016/04/22