qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA ver


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA version
Date: Tue, 26 Apr 2016 10:59:11 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

On Mon, Apr 25, 2016 at 05:04:40PM +0100, Richard W.M. Jones wrote:
> v5 -> v6:
> 
>  - Changed the xen_load_linux assertion as suggested by Stefan.
> 
>  - I renamed the variables in get_e801_addr function, since the
>    registers were really (16 bit 8086-style) AX, not EAX etc.  Also I
>    changed the GCC asm to make it a little bit more efficient.  I
>    verified by disassembling the function that GCC is still generating
>    the right code after this change.
> 
>  - Re-tested with small (342K) libguestfs initramfs and with large
>    (20M) Fedora initramfs, and works fine in both cases.
> 
> Rich.
> 
> 

Reviewed-by: Stefan Hajnoczi <address@hidden>

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]