[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 02/11] block: use the block job list in bdrv_
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH v9 02/11] block: use the block job list in bdrv_drain_all() |
Date: |
Wed, 27 Apr 2016 14:08:25 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 27 Apr 2016 02:04:33 PM CEST, Max Reitz wrote:
>> - bs = NULL;
>> - while ((bs = bdrv_next(bs))) {
>> - AioContext *aio_context = bdrv_get_aio_context(bs);
>> + while ((job = block_job_next(job))) {
>> + AioContext *aio_context = bdrv_get_aio_context(job->bs);
>
> Technically, the "bs = NULL;" before didn't do anything either. But in
> my opinion, it made the code more readable, therefore I'd really like
> a "job = NULL;" before this loop, too.
Looks reasonable, I'll update it in the next revision.
Berto
- [Qemu-devel] [PATCH v9 03/11] block: use the block job list in qmp_query_block_jobs(), (continued)
- [Qemu-devel] [PATCH v9 03/11] block: use the block job list in qmp_query_block_jobs(), Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 07/11] block: Add QMP support for streaming to an intermediate layer, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 09/11] qemu-iotests: test streaming to an intermediate layer, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 11/11] qemu-iotests: test non-overlapping block-stream operations, Alberto Garcia, 2016/04/04
- [Qemu-devel] [PATCH v9 02/11] block: use the block job list in bdrv_drain_all(), Alberto Garcia, 2016/04/04
- Re: [Qemu-devel] [PATCH for-2.7 v9 00/11] Support streaming to an intermediate layer, Stefan Hajnoczi, 2016/04/08