[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/17] vdi: Implement .bdrv_co_pwritev() interfa
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 10/17] vdi: Implement .bdrv_co_pwritev() interface |
Date: |
Wed, 27 Apr 2016 16:36:12 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 27.04.2016 um 16:17 hat Stefan Hajnoczi geschrieben:
> On Wed, Apr 27, 2016 at 11:52:40AM +0200, Kevin Wolf wrote:
> > @@ -703,6 +712,7 @@ static int vdi_co_write(BlockDriverState *bs,
> > VdiHeader *header = (VdiHeader *) block;
> > uint8_t *base;
> > uint64_t offset;
> > + uint32_t n_sectors;
> >
> > logout("now writing modified header\n");
> > assert(VDI_IS_ALLOCATED(bmap_first));
>
> Unnecessary change?
No, I removed a top-level n_sectors declaration because I wanted the
compiler to complain about any uses in the main part, which should be
byte-aligned now. This final block still uses some sector arithmetics,
though, and therefore needs to reintroduce the variable.
Kevin
pgp3XzcTz0Op5.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev, (continued)
- [Qemu-devel] [PATCH 05/17] block: Introduce .bdrv_co_preadv/pwritev BlockDriver function, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 07/17] cloop: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 08/17] dmg: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 09/17] vdi: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 10/17] vdi: Implement .bdrv_co_pwritev() interface, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 11/17] vmdk: Add vmdk_find_offset_in_cluster(), Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 12/17] vmdk: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/27
- [Qemu-devel] [PATCH 13/17] vmdk: Implement .bdrv_co_pwritev() interface, Kevin Wolf, 2016/04/27