[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 10/10] tcg: Allow goto_tb to any target PC in
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v4 10/10] tcg: Allow goto_tb to any target PC in user mode |
Date: |
Thu, 28 Apr 2016 11:03:48 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 04/20/2016 02:15 PM, Sergey Fedorov wrote:
> --- a/target-alpha/translate.c
> +++ b/target-alpha/translate.c
> @@ -464,8 +464,12 @@ static bool use_goto_tb(DisasContext *ctx, uint64_t dest)
> if (in_superpage(ctx, dest)) {
> return true;
> }
> +#ifndef CONFIG_USER_ONLY
> /* Check for the dest on the same page as the start of the TB. */
> return ((ctx->tb->pc ^ dest) & TARGET_PAGE_MASK) == 0;
> +#else
> + return true;
> +#endif
> }
>
Nit: The in_superpage test just above is for kernel mode and need not be tested
in user-only.
r~
- [Qemu-devel] [PATCH v4 08/10] tcg: Clean up tb_jmp_unlink(), (continued)
- [Qemu-devel] [PATCH v4 03/10] tcg: Rearrange tb_link_page() to avoid forward declaration, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 04/10] tcg: Init TB's direct jumps before making it visible, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 01/10] tcg: Clean up direct block chaining data fields, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 10/10] tcg: Allow goto_tb to any target PC in user mode, Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 05/10] tcg: Clarify thread safety check in tb_add_jump(), Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 06/10] tcg: Rename tb_jmp_remove() to tb_remove_from_jmp_list(), Sergey Fedorov, 2016/04/20
- [Qemu-devel] [PATCH v4 07/10] tcg: Extract removing of jumps to TB from tb_phys_invalidate(), Sergey Fedorov, 2016/04/20
- Re: [Qemu-devel] [PATCH v4 00/10] tcg: Direct block chaining clean-up, Alex Bennée, 2016/04/28