Re: [Qemu-devel] [RFC PATCH V3 1/4] colo-compare: introduce colo compare initlization

[Eric Blake]

On 04/18/2016 05:11 AM, Zhang Chen wrote:

s/initlization/initialization/ in the subject

> packet come from primary char indev will be send to
> outdev - packet come from secondary char dev will be drop

Grammar suggestion:

Packets coming from the primary char indev will be sent to outdev;
packets coming from the secondary char dev will be dropped


> Signed-off-by: Li Zhijian <address@hidden>
> Signed-off-by: Zhang Chen <address@hidden>
> Signed-off-by: Wen Congyang <address@hidden>
> ---

> +/*
> + * called from the main thread on the primary
> + * for get packets

s/get/getting/

> +++ b/qemu-options.hx
> @@ -3866,6 +3866,12 @@ Dump the network traffic on netdev @var{dev} to the 
> file specified by
>  The file format is libpcap, so it can be analyzed with tools such as tcpdump
>  or Wireshark.
>  
> address@hidden -object 
> colo-compare,address@hidden,address@hidden,address@hidden,
> address@hidden
> +
> +Colo-compare get packet from address@hidden and address@hidden,

s/get/gets/

> +and output to address@hidden, we can use it with the help of filter-mirror 
> and filter-redirector.

s/output/outputs/

Worth any better hints here about _how_ to use it with filter-mirror and
filter-redirector, or should the last phrase just be dropped?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature