[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v16 20/24] qapi: Don't pass NULL to printf in string
From: |
Eric Blake |
Subject: |
[Qemu-devel] [PATCH v16 20/24] qapi: Don't pass NULL to printf in string input visitor |
Date: |
Thu, 28 Apr 2016 15:45:28 -0600 |
Make sure the error message for visit_type_uint64() gracefully
handles a NULL 'name' when called from the top level or a list
context, as not all the world behaves like glibc in allowing
NULL through a printf-family %s.
Signed-off-by: Eric Blake <address@hidden>
---
v16: split off NULL handling
v15: new patch
---
qapi/string-input-visitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index 797973a..b55d199 100644
--- a/qapi/string-input-visitor.c
+++ b/qapi/string-input-visitor.c
@@ -222,7 +222,7 @@ static void parse_type_int64(Visitor *v, const char *name,
int64_t *obj,
return;
error:
- error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name,
+ error_setg(errp, QERR_INVALID_PARAMETER_VALUE, name ? name : "null",
"an int64 value or range");
}
--
2.5.5
- [Qemu-devel] [PATCH v16 10/24] qmp-input: Require struct push to visit members of top dict, (continued)
- [Qemu-devel] [PATCH v16 10/24] qmp-input: Require struct push to visit members of top dict, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 01/24] qapi-visit: Add visitor.type classification, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 06/24] qapi: Use strict QMP input visitor in more places, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 13/24] tests: Add check-qnull, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 14/24] qapi: Add visit_type_null() visitor, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 15/24] qmp: Support explicit null during visits, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 18/24] qmp: Tighten output visitor rules, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 24/24] qapi: Change visit_type_FOO() to no longer return partial objects, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 19/24] qapi: Split visit_end_struct() into pieces, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 16/24] spapr_drc: Expose 'null' in qom-get when there is no fdt, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 20/24] qapi: Don't pass NULL to printf in string input visitor,
Eric Blake <=
- [Qemu-devel] [PATCH v16 12/24] qapi: Document visitor interfaces, add assertions, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 21/24] tests/string-input-visitor: Add negative integer tests, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 22/24] qapi: Fix string input visitor handling of invalid list, Eric Blake, 2016/04/28
- [Qemu-devel] [PATCH v16 23/24] qapi: Simplify semantics of visit_next_list(), Eric Blake, 2016/04/28
- Re: [Qemu-devel] [PATCH v16 00/24] qapi visitor cleanups (post-introspection cleanups subset E), Markus Armbruster, 2016/04/29