[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything |
Date: |
Fri, 29 Apr 2016 09:29:33 +0100 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Thu, Apr 28, 2016 at 11:33:41PM +0200, Stefan Weil wrote:
> The clang compiler supports a useful compiler option -Weverything.
>
> As this option triggers warnings in glib header files, too, testing
> glib with -Werror will always fail. A size mismatch is also detected
> without -Werror, so simply remove it.
>
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>
> With this patch, it is possible to build QEMU using this configuration:
>
> ./configure' --cc=clang-3.7 --cxx=clang++-3.7 --extra-cflags="-Weverything
> -DHAVE_FSXATTR" --disable-werror
>
> (HAVE_FSXATTR avoids a fatal build error because of structure redefinition)
>
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index ab54f3c..abd0eff 100755
> --- a/configure
> +++ b/configure
> @@ -2967,7 +2967,7 @@ int main(void) {
> }
> EOF
>
> -if ! compile_prog "-Werror $CFLAGS" "$LIBS" ; then
> +if ! compile_prog "$CFLAGS" "$LIBS" ; then
> error_exit "sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T."\
> "You probably need to set PKG_CONFIG_LIBDIR"\
> "to point to the right pkg-config files for your"\
Reviewed-by: Daniel P. Berrange <address@hidden>
I've confirmed that this sizeof test still works as intended when the
-Werror is removed. IIRC, the -Werror usage was left over from an
earlier version of the patch
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|