qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] memory: drop find_ram_block()


From: Gonglei (Arei)
Subject: Re: [Qemu-devel] [PATCH 1/3] memory: drop find_ram_block()
Date: Fri, 29 Apr 2016 08:57:42 +0000

Hi,

> >
> > @@ -1447,8 +1432,9 @@ void qemu_ram_set_idstr(ram_addr_t addr, const
> char *name, DeviceState *dev)
> >      }
> >      pstrcat(new_block->idstr, sizeof(new_block->idstr), name);
> >
> > -    QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
> > -        if (block != new_block && !strcmp(block->idstr, new_block->idstr))
> {
> > +    QLIST_FOREACH_RCU(old_block, &ram_list.blocks, next) {
> > +        if (old_block != new_block &&
> > +            !strcmp(old_block->idstr, new_block->idstr)) {
> 
> Cosmetic point: maybe you don't need to touch these lines if you name the
> function parameter to new_block.
> 
Yes, we can.

> Reviewed-by: Fam Zheng <address@hidden>
> 
Thanks.


Regards,
-Gonglei



reply via email to

[Prev in Thread] Current Thread [Next in Thread]