Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Check if struct fsxattr is available from linux header

[Peter Maydell]

On 2 May 2016 at 13:18, Michael Tokarev <address@hidden> wrote:
> 29.04.2016 16:07, Jan Vesely пишет:
>> Fixes build failure with --enable-xfsctl and
>> new linux headers (>=4.5) and older xfsprogs(<4.5):
>> In file included from /usr/include/xfs/xfs.h:38:0,
>>                  from 
>> /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:97:
>> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of ‘struct fsxattr’
>>  struct fsxattr {
>>         ^
>> In file included from 
>> /var/tmp/portage/app-emulation/qemu-2.5.0-r1/work/qemu-2.5.0/block/raw-posix.c:60:0:
>> /usr/include/linux/fs.h:155:8: note: originally defined here
>>  struct fsxattr {
>
> This is a bug in xfsprogs, which has been fixed by a later
> release.
>
> I think it is wrong to fix it in qemu.

We have workarounds for system library bugs in various places
in QEMU, so I don't think it's a big deal to have one here too,
if it's clearly flagged as being a bug workaround.

thanks
-- PMM