qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v9 04/11] block: use the block job list in bdrv_


From: Alberto Garcia
Subject: Re: [Qemu-devel] [PATCH v9 04/11] block: use the block job list in bdrv_close()
Date: Mon, 02 May 2016 15:42:08 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Fri 29 Apr 2016 04:38:58 PM CEST, Kevin Wolf wrote:
> This is essentially the same as I'm doing here:
> http://repo.or.cz/qemu/kevin.git/commitdiff/6b545b21e3dfe2e3927cfb6bbdcc1b233c67630c

Oh, I see.

> I think I like having a separate block_job_cancel_sync_all() function
> like I did instead of inlining it in bdrv_close_all(), though that's a
> matter of taste.

Having a separate function looks good, but I don't really have a strong
opinion on this.

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]