[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for N
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for NBD |
|
Date: |
Tue, 3 May 2016 17:23:36 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.04.2016 um 20:28 hat Max Reitz geschrieben:
> Turns out NBD is not so simple to do if you do it right. Anyway, this
> series adds blockdev-add support for NBD clients.
What the series does seems to make sense to me, though things would be a
bit nicer (especially on the command line) if SocketAddress had been a
flat union from the beginning. It's too late to change now, and I guess
the ugliness isn't worth duplicating it.
I'll leave the in-detail review to our NBD folks.
Kevin