Re: [Qemu-devel] [PATCH v2 07/13] block: Move I/O throttling configuration functions to BlockBackend

[Alberto Garcia]

On Fri 22 Apr 2016 07:42:36 PM CEST, Kevin Wolf wrote:

> +void blk_set_io_limits(BlockBackend *blk, ThrottleConfig *cfg)
> +{
> +    throttle_group_config(blk, cfg);
> +}
> +
> +void blk_io_limits_disable(BlockBackend *blk)
> +{
> +    assert(blk->public.throttle_state);
> +    bdrv_no_throttling_begin(blk_bs(blk));
> +    throttle_group_unregister_blk(blk);
> +    bdrv_no_throttling_end(blk_bs(blk));
> +}
> +
> +/* should be called before bdrv_set_io_limits if a limit is set */
> +void blk_io_limits_enable(BlockBackend *blk, const char *group)

s/bdrv_set_io_limits/blk_set_io_limits/ in the comment above.

Otherwise the patch looks good to me.

Reviewed-by: Alberto Garcia <address@hidden>

Berto