Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno()

[Vikhyat Umrao]

On Fri, May 6, 2016 at 6:14 AM, Fam Zheng <address@hidden> wrote:

On Thu, 05/05 15:06, Jeff Cody wrote:
> On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote:
> > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote:
> > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001
> > > From: Vikhyat Umrao <address@hidden>
> > > Date: Mon, 2 May 2016 21:47:31 +0530
> > > Subject: [PATCH] rbd:change error_setg() to error_setg_errno()
> > >
> > > Ceph RBD block driver does not use error_setg_errno() where
> > > it is possible to use. This patch replaces error_setg()
> > > from error_setg_errno().
> > >
> > > Signed-off-by: Vikhyat Umrao <address@hidden>
> > > ---
> > >  block/rbd.c | 37 ++++++++++++++++++++++---------------
> > >  1 file changed, 22 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/block/rbd.c b/block/rbd.c
> > > index 5bc5b32..c286b32 100644
> > > --- a/block/rbd.c
> > > +++ b/block/rbd.c
> > > @@ -290,7 +290,7 @@ static int qemu_rbd_set_conf(rados_t cluster, const
> > > char *conf,
> > >              if (only_read_conf_file) {
> > >                  ret = rados_conf_read_file(cluster, value);
> > >                  if (ret < 0) {
> > > -                    error_setg(errp, "error reading conf file %s", value);
> > > +                    error_setg_errno(errp, -ret, "error reading conf file
> > > %s", value);
> >
> > Please use scripts/checkpatch.pl to scan patches for coding style
> > violations.  This line exceeds the maximum line length.
>
>
> Also, if you can use something like git send-email, it formats the patch
> emails much nicer -- which makes it easier to review & apply.

Also please use ./scripts/get_maintainer.pl to get a more complete recipient
list (for example it will report address@hidden and other block
layer maintainers).

Fam

Thank you everyone for your inputs. Sure I will fix the current patch and will check it with given scripts and then will send patch v2.