Re: [Qemu-devel] [PATCH v2 3/9] blockjob: Don't set iostatus of target

[Max Reitz]

On 27.04.2016 15:20, Kevin Wolf wrote:
> When block job errors were introduced, we assigned the iostatus of the
> target BDS "just in case". The field has never been accessible for the
> user because the target isn't listed in query-block.
> 
> Before we can allow the user to have a second BlockBackend on the
> target, we need to clean this up. If anything, we would want to set the
> iostatus for the internal BB of the job (which we can always do later),
> but certainly not for a separate BB which the job doesn't even use.
> 
> As a nice side effect, this gets us rid of another bs->blk use.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block/backup.c           | 8 ++++----
>  block/mirror.c           | 8 ++++----
>  block/stream.c           | 3 +--
>  blockjob.c               | 6 +-----
>  include/block/blockjob.h | 4 +---
>  5 files changed, 11 insertions(+), 18 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature