Re: [Qemu-devel] [PATCH] iotests: fix the redirection order in 083

[Michael Tokarev]

26.04.2016 13:13, Wei Jiangang wrote:
> It should redirect stdout to /dev/null first,
> then redirect stderr to whatever stdout currently points at.

Actually this is interesting.

By doing this like it was done initially, we see any possible
errors from grep or python, because errors will go to initial stdout.
Now, errors are sent to /dev/null too.

:)

JFYI.

/mjt

> Signed-off-by: Wei Jiangang <address@hidden>
> ---
>  tests/qemu-iotests/083 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/083 b/tests/qemu-iotests/083
> index aa99278..7d368b5 100755
> --- a/tests/qemu-iotests/083
> +++ b/tests/qemu-iotests/083
> @@ -44,7 +44,7 @@ choose_tcp_port() {
>  
>  wait_for_tcp_port() {
>       while ! (netstat --tcp --listening --numeric | \
> -              grep "$1.*0\\.0\\.0\\.0:\\*.*LISTEN") 2>&1 >/dev/null; do
> +              grep "$1.*0\\.0\\.0\\.0:\\*.*LISTEN") >/dev/null 2>&1; do
>               sleep 0.1
>       done
>  }
> @@ -71,7 +71,7 @@ EOF
>               nbd_url="nbd:127.0.0.1:$port:exportname=foo"
>       fi
>  
> -     $PYTHON nbd-fault-injector.py $extra_args "127.0.0.1:$port" 
> "$TEST_DIR/nbd-fault-injector.conf" 2>&1 >/dev/null &
> +     $PYTHON nbd-fault-injector.py $extra_args "127.0.0.1:$port" 
> "$TEST_DIR/nbd-fault-injector.conf" >/dev/null 2>&1 &
>       wait_for_tcp_port "127\\.0\\.0\\.1:$port"
>       $QEMU_IO -c "read 0 512" "$nbd_url" 2>&1 | _filter_qemu_io | _filter_nbd
>  
>