[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code
From: |
Aurelien Jarno |
Subject: |
[Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code |
Date: |
Mon, 9 May 2016 18:44:00 +0200 |
Recent versions of GCC report the following error when compiling
target-mips/helper.c:
qemu/target-mips/helper.c:542:9: warning: ‘memset’ used with length
equal to number of elements without multiplication by element size
[-Wmemset-elt-size]
This is indeed correct and due to a wrong usage of sizeof(). Fix that.
Cc: Stefan Weil <address@hidden>
Cc: Leon Alrae <address@hidden>
LP: https://bugs.launchpad.net/qemu/+bug/1577841
Signed-off-by: Aurelien Jarno <address@hidden>
---
target-mips/helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-mips/helper.c b/target-mips/helper.c
index 1004ede..cfea177 100644
--- a/target-mips/helper.c
+++ b/target-mips/helper.c
@@ -539,7 +539,7 @@ void mips_cpu_do_interrupt(CPUState *cs)
break;
case EXCP_SRESET:
env->CP0_Status |= (1 << CP0St_SR);
- memset(env->CP0_WatchLo, 0, sizeof(*env->CP0_WatchLo));
+ memset(env->CP0_WatchLo, 0, sizeof(env->CP0_WatchLo));
goto set_error_EPC;
case EXCP_NMI:
env->CP0_Status |= (1 << CP0St_NMI);
--
2.8.1
- [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code,
Aurelien Jarno <=
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Stefan Weil, 2016/05/09
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Peter Maydell, 2016/05/09
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Peter Maydell, 2016/05/09
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Christian Borntraeger, 2016/05/11
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Peter Maydell, 2016/05/11
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Christian Borntraeger, 2016/05/12
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Peter Maydell, 2016/05/12
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Cornelia Huck, 2016/05/12
- Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Christian Borntraeger, 2016/05/12
Re: [Qemu-devel] [PATCH] target-mips: fix call to memset in soft reset code, Leon Alrae, 2016/05/12