Re: [Qemu-devel] [PATCH v8 3/3] block: enable testing of LUKS driver with block I/O tests

[Daniel P. Berrange]

On Fri, May 06, 2016 at 03:32:15PM +0200, Max Reitz wrote:
> On 18.04.2016 14:21, Daniel P. Berrange wrote:
> > This adds support for testing the LUKS driver with the block
> > I/O test framework.
> > 
> >    cd tests/qemu-io-tests
> >    ./check -luks
> > 
> > A handful of test cases are modified to work with luks
> > 
> >  - 004 - whitelist luks format
> >  - 012 - use TEST_IMG_FILE instead of TEST_IMG for file ops
> >  - 048 - use TEST_IMG_FILE instead of TEST_IMG for file ops.
> >          don't assume extended image contents is all zeros,
> >          explicitly initialize with zeros
> >          Make file size smaller to avoid having to decrypt
> >          1 GB of data.
> >  - 052 - don't assume initial image contents is all zeros,
> >          explicitly initialize with zeros
> >  - 100 - don't assume initial image contents is all zeros,
> >          explicitly initialize with zeros
> 
> You're doing that with "write -P 0" in this patch. Would it be possible
> to use "write -z" instead?

Sure, I can switch that.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|