[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all
|
From: |
Jiri Denemark |
|
Subject: |
Re: [Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names |
|
Date: |
Tue, 10 May 2016 19:36:06 +0200 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Tue, May 10, 2016 at 17:19:51 +0200, Igor Mammedov wrote:
> On Fri, 6 May 2016 15:11:31 -0300
> Eduardo Habkost <address@hidden> wrote:
>
> > This makes the feature name tables in feature_word_info all match
> > the actual QOM property names we use.
> >
> > This will make the command-line interface more consistent,
> > allowing the QOM property names to be used as "-cpu" arguments
> > directly.
>
> wouldn't that change output of '-cpu help',
> can it break libvirt?
Don't worry, for any QEMU >= 1.2.0 libvirt uses only QMP commands when
probing capabilities. And currently we don't even parse feature names
anywhere, we only use feature names when constructing -cpu command line
and that parts seems to be covered by this patch.
Jirka
- Re: [Qemu-devel] [PATCH 1/9] target-i386: Move TCG initialization check to tcg_x86_init(), (continued)
- [Qemu-devel] [PATCH 2/9] target-i386: Move TCG initialization to realize time, Eduardo Habkost, 2016/05/06
- [Qemu-devel] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize, Eduardo Habkost, 2016/05/06
- [Qemu-devel] [PATCH 5/9] target-i386: Move warning code outside x86_cpu_filter_features(), Eduardo Habkost, 2016/05/06
- [Qemu-devel] [PATCH 6/9] target-i386: Define CPUID filtering functions before x86_cpu_list(), Eduardo Habkost, 2016/05/06
- [Qemu-devel] [PATCH 4/9] target-i386: List CPU models using subclass list, Eduardo Habkost, 2016/05/06
- [Qemu-devel] [PATCH 8/9] target-i386: Use "-" instead of "_" on all feature names, Eduardo Habkost, 2016/05/06
[Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions, Eduardo Habkost, 2016/05/06