Re: [Qemu-devel] [RFC 20/42] machine: add cpu-hotplug machine option

[Igor Mammedov]

On Tue, 10 May 2016 17:27:18 -0300
Eduardo Habkost <address@hidden> wrote:

> On Mon, May 02, 2016 at 02:33:29PM +0200, Igor Mammedov wrote:
> > Signed-off-by: Igor Mammedov <address@hidden>  
> 
> If a machine class simply doesn't support CPU hotplug at all, is
> silently ignoring "cpu-hotplug=on" the right thing to do?
> 
> Shouldn't we exit with an error if the machine class doesn't
> support CPU hotplug and the user tries to enable it?
We have a bunch of such options in generic MachineClass
and it was upto concrete machine to implement such checks.

So I hadn't even considered to make such check in generic code
nor think that's a right thing to do, if that's what you are asking.

But maybe I've misunderstood question.