[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 2/3] exec: adjust rcu_read_lock requirement
From: |
Gonglei |
Subject: |
[Qemu-devel] [PATCH v3 2/3] exec: adjust rcu_read_lock requirement |
Date: |
Thu, 12 May 2016 18:07:15 +0800 |
qemu_ram_unset_idstr() doesn't need rcu lock anymore,
meanwhile make the range of rcu lock in
qemu_ram_set_idstr() as small as possible.
Signed-off-by: Gonglei <address@hidden>
---
exec.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/exec.c b/exec.c
index c840bc7..117c9a8 100644
--- a/exec.c
+++ b/exec.c
@@ -1417,8 +1417,6 @@ void qemu_ram_set_idstr(RAMBlock *new_block, const char
*name, DeviceState *dev)
{
RAMBlock *block;
- rcu_read_lock();
-
assert(new_block);
assert(!new_block->idstr[0]);
@@ -1431,6 +1429,7 @@ void qemu_ram_set_idstr(RAMBlock *new_block, const char
*name, DeviceState *dev)
}
pstrcat(new_block->idstr, sizeof(new_block->idstr), name);
+ rcu_read_lock();
QLIST_FOREACH_RCU(block, &ram_list.blocks, next) {
if (block != new_block &&
!strcmp(block->idstr, new_block->idstr)) {
@@ -1449,12 +1448,9 @@ void qemu_ram_unset_idstr(RAMBlock *block)
* migration. Ignore the problem since hot-unplug during migration
* does not work anyway.
*/
-
- rcu_read_lock();
if (block) {
memset(block->idstr, 0, sizeof(block->idstr));
}
- rcu_read_unlock();
}
static int memory_try_enable_merging(void *addr, size_t len)
--
1.7.12.4