[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio bl
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access |
|
Date: |
Thu, 12 May 2016 13:26:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 12/05/2016 13:25, Paolo Bonzini wrote:
>> > r->req.aiocb = dma_blk_read(s->qdev.conf.blk, r->req.sg,
>> > r->sector,
>> > scsi_dma_complete, r);
> This is broken, it should be changed to an offset in the previous patch.
>
> Please rename the function too, so that it is obvious that you have
> changed all callers.
Oh, dma_blk_read is still sector-based...
Paolo
- [Qemu-devel] [PATCH v7 14/19] m25p80: Switch to byte-based block access, (continued)
- [Qemu-devel] [PATCH v7 14/19] m25p80: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-devel] [PATCH v7 13/19] sd: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-devel] [PATCH v7 01/19] block: Allow BDRV_REQ_FUA through blk_pwrite(), Eric Blake, 2016/05/06
- [Qemu-devel] [PATCH v7 16/19] nbd: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-devel] [PATCH v7 10/19] nand: Switch to byte-based block access, Eric Blake, 2016/05/06
- [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access, Eric Blake, 2016/05/06
- Re: [Qemu-devel] [PATCH v7 06/19] scsi-disk: Switch to byte-based aio block access, Paolo Bonzini, 2016/05/12
- Re: [Qemu-devel] [PATCH v7 00/19] block: kill sector-based blk_write/read, Kevin Wolf, 2016/05/10
- Re: [Qemu-devel] [PATCH v7 00/19] block: kill sector-based blk_write/read, Kevin Wolf, 2016/05/10