[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/12] ui patch queue
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PULL 00/12] ui patch queue |
Date: |
Thu, 12 May 2016 15:57:07 +0200 |
> Commiserations on the first failed-to-build pullreq of the 2.7 cycle:
>
> /home/pm215/qemu/ui/gtk.c: In function ‘gd_menu_copy’:
> /home/pm215/qemu/ui/gtk.c:1270:21: error: unused variable ‘vc’
> [-Werror=unused-variable]
> VirtualConsole *vc = gd_vc_find_current(s);
> ^
>
> This was on ppc64be Linux, though I'm guessing that's just because
> it's the only system that happens not to define CONFIG_VTE.
mingw builds don't have vte too, so I'm wondering now how that one
managed to escape my attention ...
> (Q: should we even put the "Copy" entry into the menu if we can't
> actually support copying text ?)
I was trying to not clutter up the patch with too many #ifdef
CONFIG_VTE. But, yes, probably we should just #ifdef the whole function
and and not add the menu entry.
cheers,
Gerd
- [Qemu-devel] [PULL 05/12] configure: add echo_version helper, (continued)
- [Qemu-devel] [PULL 05/12] configure: add echo_version helper, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 01/12] ui: gtk: fix crash when terminal inner-border is NULL, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 10/12] ui: gtk: Fix some deprecation warnings, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 07/12] configure: report SDL version, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 08/12] configure: support vte-2.91, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 09/12] ui: gtk: Fix a runtime warning on vte >= 0.37, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 03/12] configure: build SDL if only SDL2 available, Gerd Hoffmann, 2016/05/10
- [Qemu-devel] [PULL 11/12] ui/gtk: copy to clipboard support, Gerd Hoffmann, 2016/05/10
- Re: [Qemu-devel] [PULL 00/12] ui patch queue, Cole Robinson, 2016/05/10
- Re: [Qemu-devel] [PULL 00/12] ui patch queue, Peter Maydell, 2016/05/12
- Re: [Qemu-devel] [PULL 00/12] ui patch queue,
Gerd Hoffmann <=