[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readabl
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description |
Date: |
Thu, 12 May 2016 09:38:58 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/12/2016 01:47 AM, Daniel P. Berrange wrote:
> On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote:
>> The NBD protocol allows servers to advertise a human-readable
>> description alongside an export name during NBD_OPT_LIST. Add
>> an option to pass through the user's string to the NBD client.
>>
>> Doing this also makes it easier to test commit 200650d4, which
>> is the client counterpart of receiving the description.
>>
>> address@hidden -x NAME, --export-name=NAME
>> address@hidden -x, address@hidden
>
> Why this change - that reads as saying that '-x' doesn't take any value
> which is wrong IMHO
It's consistent with other options-with-arguments in the same file, such as:
@item -p, address@hidden
@item -o, address@hidden
@item -b, address@hidden
@item -k, address@hidden
etc. Basically, we want to use this common escape hatch (see 'ls
--help', for example):
Mandatory arguments to long options are mandatory for short options too.
>> address@hidden -D, address@hidden
>
> Likewise this suggests -D doesn't take a value
If you don't like it, then we should have a separate patch for the
entire file should switch over to:
@item -D @var{description}, address@hidden
style, where the mandatory option is listed for both option spellings
for every affected option.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 01/11] nbd: Use BDRV_REQ_FUA for better FUA where supported, (continued)
- [Qemu-devel] [PATCH v4 01/11] nbd: Use BDRV_REQ_FUA for better FUA where supported, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 10/11] nbd: Detect servers that send unexpected error values, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 11/11] nbd: Avoid magic number for NBD max name size, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 07/11] nbd: Clean up ioctl handling of qemu-nbd -c, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 06/11] nbd: Group all Linux-specific ioctl code in one place, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 02/11] nbd: More debug typo fixes, use correct formats, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 05/11] nbd: Reject unknown request flags, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 08/11] nbd: Limit nbdflags to 16 bits, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 03/11] nbd: Quit server after any write error, Eric Blake, 2016/05/11
- [Qemu-devel] [PATCH v4 04/11] nbd: Improve server handling of bogus commands, Eric Blake, 2016/05/11
- Re: [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance, Alex Bligh, 2016/05/12