[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL v2 14/17] egl-helpers: fix possible resource leak
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL v2 14/17] egl-helpers: fix possible resource leak |
Date: |
Fri, 13 May 2016 14:32:54 +0200 |
From: Gonglei <address@hidden>
CID 1352419, using g_strdup_printf instead of asprintf.
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/egl-helpers.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
index 558edfd..22835c0 100644
--- a/ui/egl-helpers.c
+++ b/ui/egl-helpers.c
@@ -49,18 +49,15 @@ int qemu_egl_rendernode_open(void)
continue;
}
- r = asprintf(&p, "/dev/dri/%s", e->d_name);
- if (r < 0) {
- return -1;
- }
+ p = g_strdup_printf("/dev/dri/%s", e->d_name);
r = open(p, O_RDWR | O_CLOEXEC | O_NOCTTY | O_NONBLOCK);
if (r < 0) {
- free(p);
+ g_free(p);
continue;
}
fd = r;
- free(p);
+ g_free(p);
break;
}
--
1.8.3.1
- [Qemu-devel] [PULL v2 04/17] configure: error on unknown --with-sdlabi value, (continued)
- [Qemu-devel] [PULL v2 04/17] configure: error on unknown --with-sdlabi value, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 12/17] spice/gl: add & use qemu_spice_gl_monitor_config, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 13/17] Changed malloc to g_malloc, free to g_free in ui/shader.c, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 10/17] ui: gtk: Fix some deprecation warnings, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 07/17] configure: report SDL version, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 05/17] configure: add echo_version helper, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-border is NULL, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 15/17] spice: fix coverity complains, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 09/17] ui: gtk: Fix a runtime warning on vte >= 0.37, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 03/17] configure: build SDL if only SDL2 available, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 14/17] egl-helpers: fix possible resource leak,
Gerd Hoffmann <=
- [Qemu-devel] [PULL v2 08/17] configure: support vte-2.91, Gerd Hoffmann, 2016/05/13
- Re: [Qemu-devel] [PULL v2 00/17] ui patch queue, Peter Maydell, 2016/05/13