qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io


From: Denis V. Lunev
Subject: Re: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io
Date: Mon, 16 May 2016 16:21:57 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1

On 05/16/2016 04:09 PM, Paolo Bonzini wrote:

On 14/05/2016 14:01, Denis V. Lunev wrote:
It would be convinient to enable tracepoints in qemu-io binary. This would
allow to perform investigations without additional code recompilations.

The command line will be exactly the same as in qemu-system.

Signed-off-by: Denis V. Lunev <address@hidden>
CC: Kevin Wolf <address@hidden>
CC: Paolo Bonzini <address@hidden>
---
  qemu-io.c | 43 +++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 43 insertions(+)

diff --git a/qemu-io.c b/qemu-io.c
index 5ef3ef7..2d0d2b0 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -18,6 +18,7 @@
  #include "qemu/option.h"
  #include "qemu/config-file.h"
  #include "qemu/readline.h"
+#include "qemu/log.h"
Why does this need qemu/log.h, as opposed to trace/control.h (which
probably should be moved to include/qemu/trace.h, but that's a patch for
another day)?
no, this is necessary for qemu_set_log(LOG_TRACE); which is performed as a last
step to enable tracing.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]