[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] block: remove BlockDriver.bdrv_write_comp
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] block: remove BlockDriver.bdrv_write_compressed |
Date: |
Mon, 16 May 2016 10:57:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/14/2016 06:45 AM, Denis V. Lunev wrote:
> From: Pavel Butsykin <address@hidden>
>
> There are no block drivers left that implement the old
> .bdrv_write_compressed interface, so it can be removed now.
>
> Signed-off-by: Pavel Butsykin <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: John Snow <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> +++ b/block/io.c
> @@ -1876,7 +1876,6 @@ static void bdrv_write_compressed_co_entry(void *opaque)
> int bdrv_write_compressed(BlockDriverState *bs, int64_t sector_num,
> const uint8_t *buf, int nb_sectors)
> {
> - BlockDriver *drv = bs->drv;
> BdrvWriteCompressedCo data = {
> .bs = bs,
> .sector_num = sector_num,
> @@ -1885,19 +1884,6 @@ int bdrv_write_compressed(BlockDriverState *bs,
> int64_t sector_num,
> .ret = -EINPROGRESS,
> };
>
> - if (!drv) {
> - return -ENOMEDIUM;
> - }
Why are you deleting this check?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 03/10] vmdk: add vmdk_co_write_compressed, (continued)
- [Qemu-devel] [PATCH 03/10] vmdk: add vmdk_co_write_compressed, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 02/10] qcow2: add qcow2_co_write_compressed, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 01/10] block/io: add bdrv_co_write_compressed, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 05/10] block: remove BlockDriver.bdrv_write_compressed, Denis V. Lunev, 2016/05/14
- Re: [Qemu-devel] [PATCH 05/10] block: remove BlockDriver.bdrv_write_compressed,
Eric Blake <=
- [Qemu-devel] [PATCH 07/10] blockdev-backup: added support for data compression, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 06/10] drive-backup: added support for data compression, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 09/10] block: fix backup in vmdk format image, Denis V. Lunev, 2016/05/14
- [Qemu-devel] [PATCH 08/10] qemu-iotests: test backup compression in 055, Denis V. Lunev, 2016/05/14