qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 0/5] ADB improvements


From: Programmingkid
Subject: Re: [Qemu-devel] [PATCH v3 0/5] ADB improvements
Date: Mon, 16 May 2016 16:33:44 -0400

On May 16, 2016, at 2:09 PM, Peter Maydell wrote:

> On 6 May 2016 at 03:33, Programmingkid <address@hidden> wrote:
>> This patch series makes several improvements to the ADB code. To test this 
>> code,
>> please implement the patches in the order below.
>> 
>> John Arbuckle (5):
>>  adb-keys.h: initial commit
>>  adb.c: add support for QKeyCode
>>  adb.c: correct several key assignments
>>  adb.c: prevent NO_KEY value from going to guest
>>  adb.c: add power key support
>> 
>> hw/input/adb.c              | 239 
>> +++++++++++++++++++++++++++++++++++---------
>> include/hw/input/adb-keys.h | 142 ++++++++++++++++++++++++++
>> 2 files changed, 335 insertions(+), 46 deletions(-)
>> create mode 100644 include/hw/input/adb-keys.h
> 
> Hi; I've reviewed this v3 patchset. For v4 I recommend you cc qemu-ppc,
> Alex and David, because the ADB input device is only used for the
> hw/ppc/mac* boards and I think patches for those are best routed
> via the PPC tree.

Ok.

> 
> Please also make sure you send the patches for v4 so that they
> are threaded correctly -- v3 did not come through threaded
> properly.

My git is broken in this regard. Sorry. 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]