Re: [Qemu-devel] [PATCH v3 3/5] adb.c: correct several key assignments

[Peter Maydell]

On 16 May 2016 at 21:42, Programmingkid <address@hidden> wrote:
>
> On May 16, 2016, at 2:04 PM, Peter Maydell wrote:
>
>> On 6 May 2016 at 03:37, Programmingkid <address@hidden> wrote:
>>>      /* ADB_KEY_RIGHT_COMMAND works as right super in Linux */
>>>      /* Use ADB_KEY_LEFT_COMMAND for Mac OS compatibility */
>>> -    [Q_KEY_CODE_META_R]        = 0x7e,
>>> +    [Q_KEY_CODE_META_R]        = ADB_KEY_LEFT_COMMAND,
>>
>> This looks weird. Given that the Apple Extended Keyboard
>> hardware documentation just says that both left and right
>> Command keys return 0x37, we should probably just call
>> the #define ADB_KEY_COMMAND. (That in turn means that the
>> comments are unnecessary and you can just delete them
>> from the patch you put them in.)
>
> I liked the idea of giving someone who might need to tell the
> difference between left and right command keys a way to
> accomplish their goal.

We're emulating a real bit of hardware here (ie the Apple
Extended Keyboard). If that hardware does not have distinct
left and right command keys then that's what we have to emulate.

thanks
-- PMM