|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH 4/4] kvm: support MSI_X2APIC capability |
Date: | Tue, 17 May 2016 15:13:09 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 |
On 06/05/2016 22:53, Radim Krčmář wrote: > + route->kroute.type = kvm_has_msi_x2apic() ? > KVM_IRQ_ROUTING_MSI_X2APIC > + : KVM_IRQ_ROUTING_MSI; > route->kroute.flags = 0; Perhaps using flags here instead of a new route type gives simpler code in the kernel? It's a pity that the padding field of struct kvm_irq_routing_msi was not checked against zero. :( Paolo > route->kroute.u.msi.address_lo = (uint32_t)msg.address; > route->kroute.u.msi.address_hi = msg.address >> 32;
[Prev in Thread] | Current Thread | [Next in Thread] |