qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster


From: Fam Zheng
Subject: Re: [Qemu-devel] [PATCH] backup: Fail early if cannot determine cluster size
Date: Thu, 19 May 2016 08:54:59 +0800
User-agent: Mutt/1.6.1 (2016-04-27)

On Wed, 05/18 08:25, Eric Blake wrote:
> On 05/17/2016 11:53 PM, Fam Zheng wrote:
> > Otherwise the job is orphaned and block_job_cancel_sync in
> > bdrv_close_all() when quiting will hang.
> 
> s/quiting/quitting/
> 
> > 
> > A simple reproducer is running blockdev-backup from null-co:// to
> > null-co://.
> 
> Worth a qemu-iotests addition?

Sure, as you asked, will send one in addition.

Fam

> 
> > 
> > Cc: address@hidden
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  block/backup.c | 34 ++++++++++++++++++----------------
> >  1 file changed, 18 insertions(+), 16 deletions(-)
> > 
> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 





reply via email to

[Prev in Thread] Current Thread [Next in Thread]