[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eje
|
From: |
Fam Zheng |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/1] block: clarify error message for qmp-eject |
|
Date: |
Thu, 19 May 2016 09:24:04 +0800 |
|
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Wed, 05/18 17:53, John Snow wrote:
> If you use HMP's eject but the CDROM tray is locked, you may get a
> confusing error message informing you that the "tray isn't open."
>
> As this is the point of eject, we can do a little better and help
> clarify that the tray was locked and that it (might) open up later,
> so try again.
>
> It's not ideal, but it makes the semantics of the (legacy) eject
> command more understandable to end users when they try to use it.
>
> Signed-off-by: John Snow <address@hidden>
Thanks for addressing my comments! And I like the new message a lot.
Reviewed-by: Fam Zheng <address@hidden>