[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH CFT v4 00/52] NEED_CPU_H / cpu.h / hw/hw.h clean
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH CFT v4 00/52] NEED_CPU_H / cpu.h / hw/hw.h cleanups |
Date: |
Thu, 19 May 2016 06:04:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 |
On 18.05.2016 18:36, Paolo Bonzini wrote:
> This series removes usage of NEED_CPU_H from several central
> include files in QEMU, most notably hw/hw.h and qemu-common.h.
> Definitions conditional on NEED_CPU_H remain only in disas/disas.h,
> exec/gdbstub.h, exec/helper-head.h and exec/log.h.
>
> The interesting patches are interspersed with other miscellaenous
> cleanups that I won't really dwell on in the cover letter; the main
> changes are:
>
> - make sure that target-independent code can access QOM objects
> for the CPU through an opaque type.
There still seems to be some target-specific code in some of the
cpu-qom.h headers:
$ grep -r TARGET_ target-*/cpu-qom.h
target-i386/cpu-qom.h:#ifdef TARGET_X86_64
target-mips/cpu-qom.h:#ifdef TARGET_MIPS64
target-ppc/cpu-qom.h:#ifdef TARGET_PPC64
target-ppc/cpu-qom.h:#elif defined(TARGET_PPCEMB)
target-ppc/cpu-qom.h:#if defined(TARGET_PPC64)
target-ppc/cpu-qom.h:#endif /* defined(TARGET_PPC64) */
target-sparc/cpu-qom.h:#ifdef TARGET_SPARC64
This will mainly affect the *_CPU_CLASS macros ... should these macros
now also be moved to target-*/cpu.h instead?
[...]
> As before, I would appreciate people compile-testing it on PPC. It should
> fix all the problems reported previously. The changes are available in
> the git repository at git://github.com/bonzini/qemu.git, branch need-cpu-h
I've just re-checked that branch, and now it compiles fine for me on PPC.
Thomas
- [Qemu-devel] [PATCH 32/52] explicitly include linux/kvm.h, (continued)
- [Qemu-devel] [PATCH 32/52] explicitly include linux/kvm.h, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 16/52] target-ppc: make cpu-qom.h not target specific, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 42/52] dma: do not depend on kvm_enabled(), Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 22/52] target-xtensa: make cpu-qom.h not target specific, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 02/52] s390x: move vregs_needed to machine.c, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 14/52] target-ppc: do not use target_ulong in cpu-qom.h, Paolo Bonzini, 2016/05/18
- [Qemu-devel] [PATCH 15/52] target-ppc: do not make PowerPCCPUClass depend on target-specific symbols, Paolo Bonzini, 2016/05/18
- Re: [Qemu-devel] [PATCH CFT v4 00/52] NEED_CPU_H / cpu.h / hw/hw.h cleanups,
Thomas Huth <=