[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20 |
Date: |
Fri, 20 May 2016 09:55:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 13/05/2016 14:32, Gerd Hoffmann wrote:
> @@ -1442,14 +1474,19 @@ static void gd_grab_pointer(VirtualConsole *vc, const
> char *reason)
> static void gd_ungrab_pointer(GtkDisplayState *s)
> {
> VirtualConsole *vc = s->ptr_owner;
> + GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);
>
> if (vc == NULL) {
> return;
> }
Unnecessary vc == NULL check, or possible NULL pointer dereference in
the assignment to display? (Spotted by Coverity).
Thanks,
Paolo
> s->ptr_owner = NULL;
>
> - GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);
- [Qemu-devel] [PULL v2 00/17] ui patch queue, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 11/17] ui/gtk: copy to clipboard support, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20, Gerd Hoffmann, 2016/05/13
- Re: [Qemu-devel] [PULL v2 16/17] gtk: update grab code for gtk 3.20,
Paolo Bonzini <=
- [Qemu-devel] [PULL v2 02/17] ui: sdl2: Release grab before opening console window, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 17/17] gtk: don't leak the GtkBorder with VTE 0.36, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 06/17] configure: report GTK version, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 04/17] configure: error on unknown --with-sdlabi value, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 12/17] spice/gl: add & use qemu_spice_gl_monitor_config, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 13/17] Changed malloc to g_malloc, free to g_free in ui/shader.c, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 10/17] ui: gtk: Fix some deprecation warnings, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 07/17] configure: report SDL version, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 05/17] configure: add echo_version helper, Gerd Hoffmann, 2016/05/13
- [Qemu-devel] [PULL v2 01/17] ui: gtk: fix crash when terminal inner-border is NULL, Gerd Hoffmann, 2016/05/13