[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable
|
From: |
Cole Robinson |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl |
|
Date: |
Fri, 20 May 2016 10:49:40 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 05/20/2016 01:53 AM, Gerd Hoffmann wrote:
> On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote:
>> Give users a hint if their config is wrong.
>>
>> Signed-off-by: Cole Robinson <address@hidden>
>> ---
>> If virgl support is built into qemu, virgl=on is the default, so this
>> could be noisy in cases where people don't even care about virgl. So
>> I won't object if this is dropped.
>
> Yes, it's enabled by default, so users have to flip one switch only
> (-spice gl=on) to enable 3d, not two. So warning here is a bad thing
> IMO.
>
> We could turn the virgl switch into tristate (OnOffAuto), have it
> default to Auto, then fail (not warn) in case it is set to On without 3d
> support being available.
>
Property settings are part of the migration format, right? Is there an easy
way to change the 'virgl' property like that in a backwards compatible way? Or
decouple the command line handling from the Property value?
Thanks,
Cole