qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] RFC: Make 'info snapshots' show all of snapshots with multi


From: Lin Ma
Subject: [Qemu-devel] RFC: Make 'info snapshots' show all of snapshots with multiple devices info
Date: Sun, 22 May 2016 03:55:14 -0600

Currently, the output of 'info snapshots' show fully available snapshots.
 
In my opinion there are 2 disadvantages:
1. It's opaque, hides some snapshot information to users. It's not convenient
if users want to know more about all of snapshots on every block device via 
monitor.
 
2. It uses snapshot id to determine whether the snapshots are 'fully available'.
It causes incorrect output in some scenario.
 
For instance:
(qemu) info block
drive_image1 (#block113): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk0.qcow2 (qcow2)
    Cache mode:           writeback
 
drive_image2 (#block349): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk1.qcow2 (qcow2)
    Cache mode:           writeback
(qemu) 
(qemu) info snapshots 
There is no snapshot available.
(qemu) 
(qemu) snapshot_blkdev_internal drive_image1 snap1
(qemu) 
(qemu) info snapshots 
There is no suitable snapshot available
(qemu) 
(qemu) savevm checkpoint-1
(qemu) 
(qemu) info snapshots 
ID          TAG                             VM SIZE                        DATE 
         VM CLOCK
1                snap1                                   0 2016-05-22 16:57:31  
 00:01:30.567
(qemu)

$ qemu-img snapshot -l disk0.qcow2
Snapshot list:
ID          TAG                             VM SIZE                        DATE 
         VM CLOCK
1                snap1                                   0 2016-05-22 16:57:31  
 00:01:30.567
2                checkpoint-1              165M 2016-05-22 16:58:07   
00:02:06.813

$ qemu-img snapshot -l disk1.qcow2
Snapshot list:
ID          TAG                             VM SIZE                        DATE 
         VM CLOCK
1                checkpoint-1                     0 2016-05-22 16:58:07   
00:02:06.813
 
 
 
I'd like to patch it to make the output looking like this:
(qemu) info snapshots 
 
Snapshot list from drive_image1:
ID          TAG                             VM SIZE                        DATE 
         VM CLOCK
1                snap1                                   0 2016-05-22 16:57:31  
 00:01:30.567
2                checkpoint-1              165M 2016-05-22 16:58:07   
00:02:06.813
 

Snapshot list from  drive_image2:
ID          TAG                             VM SIZE                        DATE 
         VM CLOCK
1                checkpoint-1                     0 2016-05-22 16:58:07   
00:02:06.813
 
 
any comments will be appreciated.

Thanks,
Lin


reply via email to

[Prev in Thread] Current Thread [Next in Thread]