[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 20/38] linux-user: Support for restarting system call
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PULL 20/38] linux-user: Support for restarting system calls for Microblaze targets |
Date: |
Wed, 25 May 2016 13:31:52 +0300 |
From: Timothy E Baldwin <address@hidden>
Update the Microblaze main loop and sigreturn code:
* on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn
* set all guest CPU state within signal.c code on sigreturn
* handle TARGET_QEMU_ESIGRETURN in the main loop as the indication
that the main loop should not touch any guest CPU state
Note that this in passing fixes a bug where we were corrupting
the guest r[3] on sigreturn with the guest's r[10] because
do_sigreturn() was returning env->regs[10] but the register for
syscall return values is env->regs[3].
Signed-off-by: Timothy Edward Baldwin <address@hidden>
Message-id: address@hidden
Reviewed-by: Edgar E. Iglesias <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
[PMM: Commit message tweaks; drop TARGET_USE_ERESTARTSYS define;
drop whitespace changes]
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/main.c | 7 ++++++-
linux-user/microblaze/target_signal.h | 1 +
linux-user/signal.c | 2 +-
3 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index aa6b414..40aea6e 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2982,7 +2982,12 @@ void cpu_loop(CPUMBState *env)
env->regs[9],
env->regs[10],
0, 0);
- env->regs[3] = ret;
+ if (ret == -TARGET_ERESTARTSYS) {
+ /* Wind back to before the syscall. */
+ env->sregs[SR_PC] -= 4;
+ } else if (ret != -TARGET_QEMU_ESIGRETURN) {
+ env->regs[3] = ret;
+ }
/* All syscall exits result in guest r14 being equal to the
* PC we return to, because the kernel syscall exit "rtbd" does
* this. (This is true even for sigreturn(); note that r14 is
diff --git a/linux-user/microblaze/target_signal.h
b/linux-user/microblaze/target_signal.h
index 3d1f7a7..acdf3b5 100644
--- a/linux-user/microblaze/target_signal.h
+++ b/linux-user/microblaze/target_signal.h
@@ -26,4 +26,5 @@ static inline abi_ulong get_sp_from_cpustate(CPUMBState
*state)
return state->regs[14];
}
+
#endif /* TARGET_SIGNAL_H */
diff --git a/linux-user/signal.c b/linux-user/signal.c
index b4641df..9e85550 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -3618,7 +3618,7 @@ long do_sigreturn(CPUMBState *env)
env->regs[14] = env->sregs[SR_PC];
unlock_user_struct(frame, frame_addr, 0);
- return env->regs[10];
+ return -TARGET_QEMU_ESIGRETURN;
badframe:
force_sig(TARGET_SIGSEGV);
}
--
2.1.4
- [Qemu-devel] [PULL 03/38] linux-user: Reindent signal handling, (continued)
- [Qemu-devel] [PULL 03/38] linux-user: Reindent signal handling, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 08/38] linux-user: Support for restarting system calls for MIPS targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 10/38] linux-user: Support for restarting system calls for SPARC targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 11/38] linux-user: Support for restarting system calls for SH4 targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 13/38] linux-user: Support for restarting system calls for UniCore32 targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 12/38] linux-user: Support for restarting system calls for Alpha targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 14/38] linux-user: Support for restarting system calls for OpenRISC targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 17/38] linux-user: Support for restarting system calls for CRIS targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 09/38] linux-user: Support for restarting system calls for PPC targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 15/38] linux-user: Support for restarting system calls for M68K targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 20/38] linux-user: Support for restarting system calls for Microblaze targets,
riku . voipio <=
- [Qemu-devel] [PULL 19/38] linux-user: Set r14 on exit from microblaze syscall, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 16/38] linux-user: Support for restarting system calls for S390 targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 21/38] linux-user: Add debug code to exercise restarting system calls, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 18/38] linux-user: Support for restarting system calls for tilegx targets, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 23/38] linux-user: Use safe_syscall for read and write system calls, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 22/38] linux-user: Provide safe_syscall for fixing races between signals and syscalls, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 25/38] linux-user: Use safe_syscall for wait system calls, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 24/38] linux-user: Use safe_syscall for open and openat system calls, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 28/38] linux-user: Use safe_syscall for futex syscall, riku . voipio, 2016/05/25
- [Qemu-devel] [PULL 26/38] linux-user: Use safe_syscall for execve syscall, riku . voipio, 2016/05/25