qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 23/27] iotests: 087: Disable image lock in ca


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 23/27] iotests: 087: Disable image lock in cases where file is shared
Date: Wed, 25 May 2016 15:41:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 17.05.2016 09:35, Fam Zheng wrote:
> Otherwise the error handling we are expceting will be masked by the

*expecting

> preceding image locking check, and is going to be indistinguishable
> because the error messages are all the same.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  tests/qemu-iotests/087 | 6 ++++++
>  1 file changed, 6 insertions(+)

With the spelling error fixed:

Reviewed-by: Max Reitz <address@hidden>

But maybe it would be easier to just make these test cases use null-co
instead of a qcow2 file.

> 
> diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087
> index e7bca37..60bdec5 100755
> --- a/tests/qemu-iotests/087
> +++ b/tests/qemu-iotests/087
> @@ -84,6 +84,7 @@ run_qemu <<EOF
>        "options": {
>          "driver": "$IMGFMT",
>          "id": "disk",
> +        "lock-mode": "off",
>          "node-name": "test-node",

And maybe you want to move the lock-mode below the node-name here,
because that's where you put it everywhere else in this patch.

Max

>          "file": {
>              "driver": "file",
> @@ -97,6 +98,7 @@ run_qemu <<EOF
>        "options": {
>          "driver": "$IMGFMT",
>          "id": "disk",
> +        "lock-mode": "off",
>          "file": {
>              "driver": "file",
>              "filename": "$TEST_IMG"
> @@ -109,6 +111,7 @@ run_qemu <<EOF
>        "options": {
>          "driver": "$IMGFMT",
>          "id": "test-node",
> +        "lock-mode": "off",
>          "file": {
>              "driver": "file",
>              "filename": "$TEST_IMG"
> @@ -122,6 +125,7 @@ run_qemu <<EOF
>          "driver": "$IMGFMT",
>          "id": "disk2",
>          "node-name": "disk",
> +        "lock-mode": "off",
>          "file": {
>              "driver": "file",
>              "filename": "$TEST_IMG"
> @@ -135,6 +139,7 @@ run_qemu <<EOF
>          "driver": "$IMGFMT",
>          "id": "disk2",
>          "node-name": "test-node",
> +        "lock-mode": "off",
>          "file": {
>              "driver": "file",
>              "filename": "$TEST_IMG"
> @@ -148,6 +153,7 @@ run_qemu <<EOF
>          "driver": "$IMGFMT",
>          "id": "disk3",
>          "node-name": "disk3",
> +        "lock-mode": "off",
>          "file": {
>              "driver": "file",
>              "filename": "$TEST_IMG"
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]