Re: [Qemu-devel] [PATCH v5 27/27] qemu-iotests: Add test case 153 for image locking

[Max Reitz]

On 17.05.2016 09:35, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  tests/qemu-iotests/153     | 197 +++++++++++++++++++++
>  tests/qemu-iotests/153.out | 426 
> +++++++++++++++++++++++++++++++++++++++++++++
>  tests/qemu-iotests/group   |   1 +
>  3 files changed, 624 insertions(+)
>  create mode 100755 tests/qemu-iotests/153
>  create mode 100644 tests/qemu-iotests/153.out
> 
> diff --git a/tests/qemu-iotests/153 b/tests/qemu-iotests/153
> new file mode 100755
> index 0000000..cbeda8e
> --- /dev/null
> +++ b/tests/qemu-iotests/153

[...]

> +for opts1 in "" "readonly=on" "lock-mode=off" "lock-mode=shared"; do
> +    echo
> +    echo "== Creating base image =="
> +    TEST_IMG="${TEST_IMG}.base" _make_test_img $size
> +
> +    echo
> +    echo "== Creating test image =="
> +    $QEMU_IMG create -f $IMGFMT "${TEST_IMG}" -b ${TEST_IMG}.base | 
> _filter_img_create

_make_test_img understands -b, so maybe you want to use it here.

Also I'm not sure why you're creating the images inside of this loop,
but it certainly isn't wrong.

But maybe you want to add a line that echos $opts1 somewhere here.

However you decide:

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature