[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL V3 02/20] net: mipsnet: check packet length against b
From: |
Jason Wang |
Subject: |
[Qemu-devel] [PULL V3 02/20] net: mipsnet: check packet length against buffer |
Date: |
Thu, 26 May 2016 10:16:17 +0800 |
From: Prasad J Pandit <address@hidden>
When receiving packets over MIPSnet network device, it uses
receive buffer of size 1514 bytes. In case the controller
accepts large(MTU) packets, it could lead to memory corruption.
Add check to avoid it.
Reported by: Oleksandr Bazhaniuk <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
Signed-off-by: Jason Wang <address@hidden>
---
hw/net/mipsnet.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c
index 740cd98..cf8b823 100644
--- a/hw/net/mipsnet.c
+++ b/hw/net/mipsnet.c
@@ -83,6 +83,9 @@ static ssize_t mipsnet_receive(NetClientState *nc, const
uint8_t *buf, size_t si
if (!mipsnet_can_receive(nc))
return 0;
+ if (size >= sizeof(s->rx_buffer)) {
+ return 0;
+ }
s->busy = 1;
/* Just accept everything. */
--
2.7.4
- [Qemu-devel] [PULL V3 00/20] Net patches, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 02/20] net: mipsnet: check packet length against buffer,
Jason Wang <=
- [Qemu-devel] [PULL V3 01/20] net/tap: Allocating Large sized arrays to heap, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 03/20] msix: make msix_clr_pending() visible for clients, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 04/20] pci: Introduce define for PM capability version 1.1, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 06/20] pcie: Introduce function for DSN capability creation, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 05/20] pcie: Add support for PCIe CAP v1, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 07/20] vmxnet3: Use generic function for DSN capability definition, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 08/20] net: Introduce Toeplitz hash calculator, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 10/20] vmxnet3: Use common MAC address tracing macros, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 09/20] net: Add macros for MAC address tracing, Jason Wang, 2016/05/25
- [Qemu-devel] [PULL V3 12/20] rtl8139: Move more TCP definitions to common header, Jason Wang, 2016/05/25