[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/28] io: avoid double-free when closing QIOChannelB
From: |
Amit Shah |
Subject: |
[Qemu-devel] [PULL 02/28] io: avoid double-free when closing QIOChannelBuffer |
Date: |
Thu, 26 May 2016 11:41:53 +0530 |
From: "Daniel P. Berrange" <address@hidden>
The QIOChannelBuffer's close implementation will free
the internal data buffer. It failed to reset the pointer
to NULL though, so when the object is later finalized
it will free it a second time with predictable crash.
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
---
io/channel-buffer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/io/channel-buffer.c b/io/channel-buffer.c
index 3e5117b..43d7959 100644
--- a/io/channel-buffer.c
+++ b/io/channel-buffer.c
@@ -140,6 +140,7 @@ static int qio_channel_buffer_close(QIOChannel *ioc,
QIOChannelBuffer *bioc = QIO_CHANNEL_BUFFER(ioc);
g_free(bioc->data);
+ bioc->data = NULL;
bioc->capacity = bioc->usage = bioc->offset = 0;
return 0;
--
2.5.5
- [Qemu-devel] [PULL 00/28] migration: support for TLS, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 01/28] s390: use FILE instead of QEMUFile for creating text file, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 03/28] migration: remove use of qemu_bufopen from vmstate tests, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 02/28] io: avoid double-free when closing QIOChannelBuffer,
Amit Shah <=
- [Qemu-devel] [PULL 04/28] migration: ensure qemu_fflush() always writes full data amount, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 07/28] migration: force QEMUFile to blocking mode for outgoing migration, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 05/28] migration: split migration hooks out of QEMUFileOps, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 06/28] migration: introduce set_blocking function in QEMUFileOps, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 11/28] migration: convert post-copy to use QIOChannelBuffer, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 08/28] migration: introduce a new QEMUFile impl based on QIOChannel, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 12/28] migration: convert unix socket protocol to use QIOChannel, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 09/28] migration: add helpers for creating QEMUFile from a QIOChannel, Amit Shah, 2016/05/26
- [Qemu-devel] [PULL 10/28] migration: add reporting of errors for outgoing migration, Amit Shah, 2016/05/26