Re: [Qemu-devel] [PATCH v5 06/27] block: Make bdrv_reopen_{commit, abort} private functions

[Fam Zheng]

On Tue, 05/24 18:09, Max Reitz wrote:
> On 17.05.2016 09:35, Fam Zheng wrote:
> > As parts of the transactional reopen, they are not necessary outside
> > block.c. Make them static.
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  block.c               | 6 ++++--
> >  include/block/block.h | 2 --
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/block.c b/block.c
> > index 1b42303..ad3663c 100644
> > --- a/block.c
> > +++ b/block.c
> > @@ -1943,6 +1943,8 @@ BlockReopenQueue *bdrv_reopen_queue(BlockReopenQueue 
> > *bs_queue,
> >   * to all devices.
> >   *
> >   */
> > +static void bdrv_reopen_commit(BDRVReopenState *reopen_state);
> > +static void bdrv_reopen_abort(BDRVReopenState *reopen_state);
> 
> I'd rather put these declarations above the comment describing
> bdrv_reopen_multiple(); or just at the top of the file, we have two such
> declarations there already.

Right, moving them to above the comment.

Fam