[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus lis
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [for-2.7 PATCH v3 01/15] exec: Remove cpu from cpus list during cpu_exec_exit() |
Date: |
Fri, 27 May 2016 11:51:20 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 27/05/2016 05:07, David Gibson wrote:
> On Thu, May 26, 2016 at 12:12:41PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 12/05/2016 05:48, Bharata B Rao wrote:
>>> CPUState *cpu gets added to the cpus list during cpu_exec_init(). It
>>> should be removed from cpu_exec_exit().
>>>
>>> cpu_exec_exit() is called from generic CPU::instance_finalize and some
>>> archs like PowerPC call it from CPU unrealizefn. So ensure that we
>>> dequeue the cpu only once.
>>
>> I think the better thing would be to call it from CPU::unrealize, but
>> this patch is okay too.
>>
>> Thanks,
>>
>> Paolo
>
> Thanks for the review Paolo.
>
> However, what I'm really unclear on is what is the next step towards
> merging these. Will you take them through your tree? Should Bharata
> send a formal pull request with the prelim patches? If so, to whom?
Feel free to take them and add an Acked-by for me. The fewer patches I
merge, the better. :)
Thanks,
Paolo
- [Qemu-devel] [for-2.7 PATCH v3 00/15] Core based CPU hotplug for PowerPC sPAPR, Bharata B Rao, 2016/05/11
- [Qemu-devel] [for-2.7 PATCH v3 05/15] qdev: hotplug: Introduce HotplugHandler.pre_plug() callback, Bharata B Rao, 2016/05/11
- [Qemu-devel] [for-2.7 PATCH v3 04/15] cpu: Add a sync version of cpu_remove(), Bharata B Rao, 2016/05/11
- [Qemu-devel] [for-2.7 PATCH v3 06/15] cpu: Abstract CPU core type, Bharata B Rao, 2016/05/11
- [Qemu-devel] [for-2.7 PATCH v3 11/15] spapr_drc: Prevent detach racing against attach for CPU DR, Bharata B Rao, 2016/05/11
- [Qemu-devel] [for-2.7 PATCH v3 08/15] spapr: convert boot CPUs into CPU core devices, Bharata B Rao, 2016/05/11
- [Qemu-devel] [for-2.7 PATCH v3 03/15] cpu: Reclaim vCPU objects, Bharata B Rao, 2016/05/11