[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence
From: |
Pranith Kumar |
Subject: |
Re: [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence |
Date: |
Fri, 27 May 2016 10:17:17 -0400 |
Hi Sergey,
Sergey Fedorov writes:
> On 27/05/16 04:00, Richard Henderson wrote:
>> diff --git a/tci.c b/tci.c
>> index b488c0d..53b3f71 100644
>> --- a/tci.c
>> +++ b/tci.c
>> @@ -1236,6 +1236,9 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t
>> *tb_ptr)
>> tcg_abort();
>> }
>> break;
>> + case INDEX_op_fence:
>> + smp_mb();
>> + break;
>> default:
>> TODO();
>> break;
>
> A bit of bike-shedding. While there's no common ISA term for "memory
> barrier" (also known as a "membar", "memory fence", etc.), we already
> refer to it as a "memory barrier" (or "mb") in include/qemu/atomic.h and
> docs/atomics.txt. Why don't be consistent and avoid introducing yet
> another term for the same thing?
>
Fair point. Do you think tcg_out_mb() is better then?
Thanks,
--
Pranith
- Re: [Qemu-devel] [PATCH v2 01/12] Introduce TCGOpcode for fence instruction, (continued)
- [Qemu-devel] [PATCH v2 06/12] tcg/mips: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 05/12] tcg/ia64: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 08/12] tcg/s390: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 09/12] tcg/sparc: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 02/12] tcg/i386: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 07/12] tcg/ppc: Add support for fence, Richard Henderson, 2016/05/26
- [Qemu-devel] [PATCH v2 10/12] tcg/tci: Add support for fence, Richard Henderson, 2016/05/26
[Qemu-devel] [PATCH v2 11/12] target-arm: Add frontend support for fence gen in ARMv7, Richard Henderson, 2016/05/26
[Qemu-devel] [PATCH v2 12/12] target-alpha: Generate fence opcodes, Richard Henderson, 2016/05/26
Re: [Qemu-devel] [PATCH v2 00/12] tcg: Add fence opcode, Pranith Kumar, 2016/05/27