Re: [Qemu-devel] [PATCH v6 13/15] qht: add test-qht-par to invoke qht-bench from 'check' target

[Sergey Fedorov]

On 25/05/16 04:13, Emilio G. Cota wrote:
> diff --git a/tests/test-qht-par.c b/tests/test-qht-par.c
> new file mode 100644
> index 0000000..fc0cb23
> --- /dev/null
> +++ b/tests/test-qht-par.c
> @@ -0,0 +1,56 @@
(snip)
> +
> +#define TEST_QHT_STRING "tests/qht-bench 1>/dev/null 2>&1 -R -S0.1 -D10000 
> -N1"
> +
> +static void test_qht(int n_threads, int update_rate, int duration)
> +{
> +    char *str;
> +    int rc;
> +
> +    str = g_strdup_printf(TEST_QHT_STRING "-n %d -u %d -d %d",

There needs to be an extra space either at the beginning of the literal
string, or at the end of the string defined by TEST_QHT_STRING, so that
we don't get "... -N1-n ...".

> +                          n_threads, update_rate, duration);
> +    rc = system(str);
> +    g_free(str);
> +    g_assert_cmpint(rc, ==, 0);
> +}
> +
>

Kind regards,
Sergey